Simplifying backgrounds to match lightgray in service-ui and ui-compo… #3011
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The highlighting of the controls at the top is rather faint. |
|
What if I shift up the darkness of both 'secondary-color's?
|
|
That looks fine. |
fbarl
reviewed
Jan 3, 2018
|
Thanks! That's fixed now.
|
|
...which has just reminded me to ask... why is there such a huge gap between the top controls and the table? Vertical space is precious here; the table should use as much as it can. Separate issue, clearly. |
Ah, I think it's there to accommodate the expansion of the top when timetravelling. |
|
@rade, but it shouldn't be that way when in Live mode? |
Ideally not, no. Have filed #3015. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nents
Breaks unless service-ui is also updated to https://github.com/weaveworks/service-ui/pull/1672
The corresponding gray shift in Explore to addresses the issues in weaveworks/ui-components#93
Trying to consolidate and simplify some colouring and settled on this after quite a few more more drastic attempts..
Is this enough contrast?